Difference between revisions of "User:Positive/Optimal Velocity"

From Robowiki
Jump to navigation Jump to search
(Argh.. the updateMovement() method used in our 1.7.1.4 Alpha version is/was buggy, which have an impact on the scores and hence the results! :-()
m (Using <syntaxhighlight>.)
 
(45 intermediate revisions by 6 users not shown)
Line 3: Line 3:
 
I believe this is the correct getClosestReachableVelocityToVelocity function (feel free to comment):
 
I believe this is the correct getClosestReachableVelocityToVelocity function (feel free to comment):
  
−
<pre>
+
<syntaxhighlight>
 
double getClosestReachableVelocityToVelocity(double currentVelocity,double wantedVelocity)
 
double getClosestReachableVelocityToVelocity(double currentVelocity,double wantedVelocity)
 
{
 
{
Line 54: Line 54:
 
  }
 
  }
 
}  
 
}  
−
</pre>
+
</syntaxhighlight>
  
 
getMaxVelocity function by Voidious:
 
getMaxVelocity function by Voidious:
−
<pre>
+
<syntaxhighlight>
 
     double getMaxVelocity(double distance)
 
     double getMaxVelocity(double distance)
 
     {
 
     {
Line 84: Line 84:
 
         return i * i;
 
         return i * i;
 
     }
 
     }
−
</pre>
+
</syntaxhighlight>
  
 
The getNewVelocity function:
 
The getNewVelocity function:
−
<pre>
+
<syntaxhighlight>
 
     double getNewVelocity(double velocity, double distance) {
 
     double getNewVelocity(double velocity, double distance) {
 
     if(distance<0)
 
     if(distance<0)
Line 98: Line 98:
 
           // return whatever is closest to that velocity
 
           // return whatever is closest to that velocity
 
     }
 
     }
−
</pre>
+
</syntaxhighlight>
  
 
Simulator:
 
Simulator:
−
<pre>
+
<syntaxhighlight>
  
 
     public void simulate()
 
     public void simulate()
Line 114: Line 114:
 
     }
 
     }
 
     }
 
     }
−
</pre>
+
</syntaxhighlight>
  
 
== Results ==
 
== Results ==
Line 172: Line 172:
 
</pre>
 
</pre>
  
−
== Suggested updateMovement code ==
+
== Original game updateMovement code ==
  
−
Original updateMovement code:
+
<syntaxhighlight>
−
<pre>
 
 
     private void updateMovement() {
 
     private void updateMovement() {
 
         double distance = currentCommands.getDistanceRemaining();
 
         double distance = currentCommands.getDistanceRemaining();
Line 199: Line 198:
 
         }
 
         }
 
     }
 
     }
−
</pre>
+
</syntaxhighlight>
 +
 
 +
== Suggested updateMovement code Positive ==
  
 
Now I'm thinking, if the distance remaining == 0.0, and the velocity is set from 6.0 to 4.0, shouldnt the distance remaining become -4.0? Also, the updateBoundingBox is called whenever velocity!=0, because the condition dx==0 && dy==0 is only when the velocity==0, so that can be easier to check. I suggest:
 
Now I'm thinking, if the distance remaining == 0.0, and the velocity is set from 6.0 to 4.0, shouldnt the distance remaining become -4.0? Also, the updateBoundingBox is called whenever velocity!=0, because the condition dx==0 && dy==0 is only when the velocity==0, so that can be easier to check. I suggest:
  
−
<pre>
+
<syntaxhighlight>
 
     private void updateMovement() {
 
     private void updateMovement() {
 
         double distance = currentCommands.getDistanceRemaining();
 
         double distance = currentCommands.getDistanceRemaining();
Line 222: Line 223:
 
currentCommands.setDistanceRemaining(distance - velocity);
 
currentCommands.setDistanceRemaining(distance - velocity);
 
     }
 
     }
−
</pre>
+
</syntaxhighlight>
 +
 
 +
== Corrected updateMovement code ==
  
 
When I run your suggested version against the unit test for 1.6.1.4, I get an error. After some studying and experiments, I found out that the updateMovement() method used in 1.7.1.3 (the "original" on this page) and your suggested version are both buggy. The problem is that the remaining distance is incorrect. The bugfree version compared to 1.6.1.4 is this version:
 
When I run your suggested version against the unit test for 1.6.1.4, I get an error. After some studying and experiments, I found out that the updateMovement() method used in 1.7.1.3 (the "original" on this page) and your suggested version are both buggy. The problem is that the remaining distance is incorrect. The bugfree version compared to 1.6.1.4 is this version:
  
−
<pre>
+
<syntaxhighlight>
 
private void updateMovement() {
 
private void updateMovement() {
 
double distance = currentCommands.getDistanceRemaining();
 
double distance = currentCommands.getDistanceRemaining();
Line 246: Line 249:
 
}
 
}
 
}
 
}
 +
</syntaxhighlight>
 +
 +
The problem was, that is the robot has a velocity of e.g. 8, and we call setAhead(0), the remaining distance would be set to 0. But this is not correct, as the robot needs to brake first, and will move at least 6 + 4 + 2 = 12 pixels more, meaining that it should end with a remaining distance of -12. My new version about take this into account and works in the 1.6.1.4 code. Unfortunately this also means that our Alpha versions are buggy, as I used this improved version for all of them. That might explain the "big" differences in score! I am affraid that we need to do new alphas and retest them all with this issue in mind. Argh! What to do? Should we make new alphas for Hijack 1 and 2 etc. and retest? We could do this + we gain benefits of all bugfixes that have been made since 1.7.1.3. --[[User:FlemmingLarsen|Fnl]] 22:04, 7 August 2009 (UTC)
 +
 +
Thankyou for taking the time to investigate this, could you please expand on why you added:
 +
 +
<syntaxhighlight>
 +
if (velocity == 0) {
 +
currentCommands.setDistanceRemaining(0);
 +
}
 +
</syntaxhighlight>
 +
 +
Say you are at -2 velocity, and set distance to travel=100. Wouldn't that code cause distance to travel to be incorrectly set to 0? --[[User:Positive|Positive]] 23:06, 7 August 2009 (UTC)
 +
 +
[[Fnl]], what I think you are trying to do is prevent bots from reversing back to their original position if setAhead(0) is called? You shouldn't do that by checking if <code>velocity == 0</code> but rather by checking if <code>distance == 0</code> because velocity has nothing to do with what the bot passed as an arguments, distance is. So rather have the updateMovement() method as:
 +
<syntaxhighlight>
 +
    private void updateMovement() {
 +
double distance = currentCommands.getDistanceRemaining();
 +
 +
        if (Double.isNaN(distance)) {
 +
distance = 0;
 +
        }
 +
 +
        velocity = getNewVelocity(velocity, distance);
 +
 +
if(velocity!=0)
 +
{
 +
x += velocity * sin(bodyHeading);
 +
y += velocity * cos(bodyHeading);
 +
updateBoundingBox();
 +
}
 +
        if(distance != 0)
 +
currentCommands.setDistanceRemaining(distance - velocity);
 +
    }
 +
</syntaxhighlight>
 +
--[[User:Skilgannon|Skilgannon]] 23:21, 7 August 2009 (UTC)
 +
 +
Yes, I believe your version is correct, and that my newest version is buggy (too). Actually, I was using the "if(distance != 0)" in my original code for 1.7.1.3. It seems to work better. And running on the old test cases for 1.6.1.4 shows that the previous version only covers some parts of the errors I saw yesterday with the suggested updateMovement from Positive.
 +
 +
Doh! This means that the new alphas I made yesterday (5, 6, 7) are incorrect too! :-\
 +
 +
Okay, so we should wait on doing new tests, and create new Alphas again, again. I need to try out this new version too. --[[User:FlemmingLarsen|Fnl]] 13:16, 8 August 2009 (UTC)
 +
 +
[[User:Skilgannon|Skilgannon]], it seems your version is buggy too. The problem is that is does not take the braking scenario into account I described earlier. E.g. if the robot is moving at velocity 8, has quite some remaining distance left, and then we call setAhead(0), the robot should end with a remaining distance = -12 after the braking has stopped.
 +
* Time n+0: Velocity = 8, remaining distance = 1000 -> Now we call setAhead(0)
 +
* Time n+1: Velocity = 8, remaining distance = 0
 +
* Time n+2: Velocity = 6, remaining distance = -6
 +
* Time n+3: Velocity = 4, remaining distance = -10
 +
* Time n+4: Velocity = 2, remaining distance = -12
 +
* Time n+5: Velocity = 0, remaining distance = -12 -> We have finally stopped
 +
 +
This scenario must be taken into account in order to stay compatible with 1.6.1.4. I guess we need a seperate variable to keep track of the user's setAhead/Back(x) request. --[[User:FlemmingLarsen|Fnl]] 13:48, 8 August 2009 (UTC)
 +
 +
: Isn't it should be
 +
 +
:
 +
:* Time n+0: Velocity = 8, remaining distance = 1000 -> Now we call setAhead(0)
 +
:* Time n+1: Velocity = 6, remaining distance = -6
 +
:* Time n+2: Velocity = 4, remaining distance = -10
 +
:* Time n+3: Velocity = 2, remaining distance = -12
 +
:* Time n+4: Velocity = 0, remaining distance = -12 -> We have finally stopped
 +
 +
:? Because robot did move once more in each tick. &raquo; <span style="font-size:0.9em;color:darkgreen;">[[User:Nat|Nat]] | [[User_talk:Nat|Talk]]</span> &raquo; 14:59, 8 August 2009 (UTC)
 +
:: Yes, you are right here. :-) --[[User:FlemmingLarsen|Fnl]] 21:28, 8 August 2009 (UTC)
 +
 +
Let see if this work...
 +
<syntaxhighlight>
 +
 +
boolean isOverDriving = false;
 +
 +
private void updateMovement() {
 +
double distance = currentCommands.getDistanceRemaining();
 +
 +
      if (Double.isNaN(distance)) {
 +
distance = 0;
 +
      }
 +
 +
      velocity = getNewVelocity(velocity, distance);
 +
 +
if (velocity == 0 && isOverDriving) {
 +
currentCommands.setDistanceRemaining(0);
 +
isOverDriving = false;
 +
}
 +
 +
if (Math.signum(distance * velocity) != -1) {
 +
if (getDistanceTraveledUntilStop(velocity) > Math.abs(distance))
 +
isOverDriving = true;
 +
else
 +
isOverDriving = false;
 +
}
 +
 +
if(velocity != 0) {
 +
x += velocity * sin(bodyHeading);
 +
y += velocity * cos(bodyHeading);
 +
updateBoundingBox();
 +
}
 +
     
 +
if(distance != 0)
 +
currentCommands.setDistanceRemaining(distance - newVelocity);
 +
}
 +
 +
private double getDistanceTraveledUntilStop(double velocity) {
 +
double distance = 0;
 +
velocity = Math.abs(velocity);
 +
while (velocity > 0)
 +
distance += (velocity = getNewVelocity(velociy, 0));
 +
return distance;
 +
}
 +
 +
</syntaxhighlight>
 +
 +
&raquo; <span style="font-size:0.9em;color:darkgreen;">[[User:Nat|Nat]] | [[User_talk:Nat|Talk]]</span> &raquo; 14:21, 8 August 2009 (UTC)
 +
 +
Testing using hacked Darkcanuck's VelocityTest, my version seems to work fine. &raquo; <span style="font-size:0.9em;color:darkgreen;">[[User:Nat|Nat]] | [[User_talk:Nat|Talk]]</span> &raquo; 14:59, 8 August 2009 (UTC)
 +
 +
Fnl, with the version I posted as suggestion to the original, it should work like you said. I really can't see why it wouldn't work. To check we are on the same page, if the robot is at 8 velocity, and setAhead(0) is set, it should move backwards after it has overshot, right? If you look at the version I posted, you see the line:
 +
 +
<syntaxhighlight>
 +
currentCommands.setDistanceRemaining(distance - velocity);
 +
    }
 +
</syntaxhighlight>
 +
 +
Lets say distance is set to 0, and velocity is set to 6. Then distance remaining will be set here to (0 - 6) = -6. And after that (-6 - 4) = -10. Etc. --[[User:Positive|Positive]] 17:27, 8 August 2009 (UTC)
 +
 +
[[User:Positive|Positive]], I ran my test again with your version. I am sorry that I wrote that the problem with your version is the remaining distance. This is ''not'' the case, as it is perfect in your version. The problem with your version is that when the robot is braking, it does not stop at velocity = 0. It continues to velocity = -1 in the next turn, and afterward -2, where it should have stopped at velocity = 0. This can be seen with the TestBodyTurnRate (using the BodyTurnRate test robot). The additonal check ''if(distance != 0)'' by [[User:Skilgannon|Skilgannon]] fixes this problem, but wrecks the remaining distance. So we need a method to take both issues into account. :-p Now I will check out [[User:Nat|Nat]]'s version. I cross my fingers that his version works. --[[User:FlemmingLarsen|Fnl]] 21:15, 8 August 2009 (UTC)
 +
 +
Hrm, but what would be the use of getting a distance of -12 at velocity=0, if the robot doesn't try to get to 0 distance by going -1, -2 etc.? I'll try to test with that robot to see what you mean. --[[User:Positive|Positive]] 21:47, 8 August 2009 (UTC)
 +
 +
== FNL's test robot ==
 +
Okay, I guees I need to provide a sample robot + give the result I expect so you are able to follow what I am talking about. ;-)
 +
Basically, I just want us to be compatible with version 1.6.1.4, at least for the following test.
 +
 +
This robot will show a simple movement:
 +
<syntaxhighlight>
 +
public class TestVelocityAndRemainingDist extends robocode.AdvancedRobot {
 +
public void run() {
 +
// Set far ahead
 +
setAhead(1000);
 +
 +
// Execute for 9 turns
 +
for (int i = 0; i < 9; i++) {
 +
executeAndDump();
 +
}
 +
 +
// Stop moving
 +
stopMovingAndDump();
 +
}
 +
 +
private void executeAndDump() {
 +
double lastVelocity = getVelocity();
 +
double distanceRemaining = getDistanceRemaining();
 +
 +
execute();
 +
 +
out.println(getTime() + ": " + lastVelocity + ", " + distanceRemaining);
 +
}
 +
 +
private void stopMovingAndDump() {
 +
setAhead(0);
 +
setTurnLeft(0);
 +
 +
for (int i = 0; i < 7; i++) {
 +
executeAndDump();
 +
}
 +
}
 +
}
 +
</syntaxhighlight>
 +
 +
The results (robot output) we get when running this robot in version 1.6.1.4 is:
 +
<pre>
 +
1: 0.0, 1000.0
 +
2: 1.0, 999.0
 +
3: 2.0, 997.0
 +
4: 3.0, 994.0
 +
5: 4.0, 990.0
 +
6: 5.0, 985.0
 +
7: 6.0, 979.0
 +
8: 7.0, 972.0
 +
9: 8.0, 964.0
 +
10: 8.0, 0.0
 +
11: 6.0, -6.0
 +
12: 4.0, -10.0
 +
13: 2.0, -12.0
 +
14: 0.0, 0.0
 +
15: 0.0, 0.0
 +
16: 0.0, 0.0
 +
</pre>
 +
 +
Here the first number is the turn, the second row is the velocity, and the third row is the remaining distance.
 +
 +
--[[User:FlemmingLarsen|Fnl]] 21:54, 8 August 2009 (UTC)
 +
 +
When I test using [[User:Positive|Positive]]'s updateMovement, I get almost the same, but have problems with the velocity in the end:
 +
<pre>
 +
...
 +
13: 2.0, -12.0
 +
14: 0.0, -12.0
 +
15: -1.0, -11.0
 +
16: -2.0, -10.0
 +
</pre>
 +
 +
That is, the velocity should end at 0. So this is bad compared to 1.6.1.4.
 +
 +
When I test using [[User:Skilgannon|Skilgannon]]'s and also [[User:Nat|Nat]]'s version of updateMovement, I end with (in both cases):
 +
 +
<pre>
 +
...
 +
10: 8.0, 0.0
 +
11: 6.0, 0.0
 +
12: 4.0, 0.0
 +
13: 2.0, 0.0
 +
14: 0.0, 0.0
 +
15: 0.0, 0.0
 +
16: 0.0, 0.0
 +
</pre>
 +
 +
Here the remaining distance is wrong compared to 1.6.1.4.
 +
 +
--[[User:FlemmingLarsen|Fnl]] 22:13, 8 August 2009 (UTC)
 +
 +
(Edit conflict) Okay, so lets say the current velocity is positive, the pseudocode would be (for your suggested behaviour):
 +
 +
<pre>
 +
if remaining distance is positive:
 +
  the next velocity is the closest possible to the max velocity without overshooting
 +
  the next remaining distance is current remaining distance - next velocity
 +
if remaining distance is negative:
 +
  the next velocity is the closest possible to 0
 +
  if the next velocity is 0:
 +
    the next remaining distance becomes 0
 +
  else
 +
    the next remaining distance becomes current remaining distance - next velocity
 +
</pre>
 +
 +
Is this correct? --[[User:Positive|Positive]] 22:16, 8 August 2009 (UTC)
 +
: Yes, this looks right to me. :-) --[[User:FlemmingLarsen|Fnl]] 22:31, 8 August 2009 (UTC)
 +
: No, if you move backward you will have negative distance remaining and velocity. &raquo; <span style="font-size:0.9em;color:darkgreen;">[[User:Nat|Nat]] | [[User_talk:Nat|Talk]]</span> &raquo; 23:57, 8 August 2009 (UTC)
 +
: Actually, I said "lets say the current velocity is positive". But now I recheck it, the pseudocode would give problems with robots that are at say 8 velocity and want to move -100 (backwards). They'd be cut off at 0 from doing the total move. It's a difficult question, and I think the proposal at the end of this page would be best, leaving the original code as is. --[[User:Positive|Positive]] 00:03, 9 August 2009 (UTC)
 +
 +
Heh, and if I make this little tweak and run in 1.6.1.4:
 +
<syntaxhighlight>
 +
private void stopMovingAndDump() {
 +
setAhead(-0.01);
 +
setTurnLeft(0);
 +
 +
for (int i = 0; i < 13; i++) {
 +
executeAndDump();
 +
}
 +
}
 +
</syntaxhighlight> it gives <pre>1: 0.0, 1000.0
 +
2: 1.0, 999.0
 +
3: 2.0, 997.0
 +
4: 3.0, 994.0
 +
5: 4.0, 990.0
 +
6: 5.0, 985.0
 +
7: 6.0, 979.0
 +
8: 7.0, 972.0
 +
9: 8.0, 964.0
 +
10: 8.0, -0.01
 +
11: 6.0, -6.01
 +
12: 4.0, -10.01
 +
13: 2.0, -12.01
 +
14: 0.0, -12.01
 +
15: -1.0, -11.01
 +
16: -2.0, -9.01
 +
17: -3.0, -6.01
 +
18: -4.0, -2.01
 +
19: -2.0, -0.009999999999999787
 +
20: -0.009999999999999787, 0.0
 +
21: 0.0, 0.0
 +
22: 0.0, 0.0
 +
</pre> showing how near-zero values behave. Ugh... this highly inconsistant behavior between near-zero and zero makes me tempted to suggest something like having setAhead() behave like 1.6.1.4, but make something like a setBetterAhead() with more intuitive/sane behavior. Personally, I can think of little usefulness of the old setAhead() behavior in a new bot, except to annoy the bot author. If an author wants the bot to coast to a stop, the stop() function makes much more sense. Every single movement I've personally written, or seen anyone else write, is based upon either a "goToPoint()" style method, a "setVelocity()" style method, or is a simple oscillator. For simple oscillators or "setVelocity()" method the "setAhead(0)" condition likely never occurs. For a "goToPoint()" style, "setAhead(0)" will almost always be intended to mean "go where I am now". The ONLY case in which I can see people thinking the current behavior of "setAhead(0)" makes sense, is if what they REALLY meant was "setVelocity(0)". --[[User:Rednaxela|Rednaxela]] 22:28, 8 August 2009 (UTC)
 +
: I really agree with you that the setAhead() and stop is not really intuitive. It fooled me many times as I always forget how it behaves. However, I have never dared to change that as I would break the compatibility and rankings in RoboRumble. ;-) Your idea with setVelocity(0) reminds me of the new robot type in Robocode named [http://robocode.sourceforge.net/docs/robocode/robocode/RateControlRobot.html RateControlRobot]. Go have a look. :-) --[[User:FlemmingLarsen|Fnl]] 22:42, 8 August 2009 (UTC)
 +
:: Interesting, though three things 1) I doubt people really care about the 'rate' often for anything except velocity, 2) Err "setVelocityRate()" seems like a major misnomer. Velocity is the rate of movement, and the rate at which velocity moves is acceleration, so "setVelocityRate()" would logically imply acceleration rather than what it says in those API docs, 3) Since it extends AdvancedRobot and not TeamRobot, you can't use it in a team robot. --[[User:Rednaxela|Rednaxela]] 22:53, 8 August 2009 (UTC)
 +
:: 1) Once in a while people have requested this type of robot in order to "simulate" a real robot. So why not? 2) You are right. I need to do some work here. ;-) 3) Again a very good point! This should be easy to fix, and I will. :-) --[[User:FlemmingLarsen|Fnl]] 23:03, 8 August 2009 (UTC)
 +
:: Oh, and also, here's how I deal with setting velocity in all of my recent bots these days: [[User:Rednaxela/BotBase#MovementActor.java]] --[[User:Rednaxela|Rednaxela]] 23:08, 8 August 2009 (UTC)
 +
 +
Just for the record, I forgot to add the test result for my updateMovement method from yesterday against the TestVelocityAndRemainingDist robot. My version seems works perfect in this specific scenario. But I am still not sure if it is 100% correct. --[[User:FlemmingLarsen|Fnl]] 22:31, 8 August 2009 (UTC)
 +
 +
I think like Rednaxela it seems illogical that the distance should first become -12, and then be set to 0 when velocity=0 is reached. I believe there are 2 options:
 +
 +
# The overshot is added to the remaining distance (my first suggested code).
 +
# Nothing is added to the remaining distance and it stays the same until the robot travels in the right direction. That means that remaining distance would stay at 0 if a robot sets setAhead(0), but will eventually move backwards only by -2 if set with setAhead(-2) independant of what the initial velocity was.
 +
 +
Otherwise what Rednaxela posted will happen (setAhead(-0.01) being treated completely different from setAhead(0)). --[[User:Positive|Positive]] 22:40, 8 August 2009 (UTC)
 +
 +
I am not sure what to do. It seems to be most of you want to stick to the behaviour from 1.6.1.4, even if it is odd and hard to understand the behavior. The reason being that you do not want to wreck rankings etc. for the RoboRumble, which is reasonable, but also to allow old robots to run the same way as in previous versions. In the discussion of old versus new rules, most people seems to want stick to the old rules, but without the bugs that can be fixed with little impact. So if we change the rules with the remaining distance here compared to 1.6.1.4, this might have an impact on both compatibility and rankings. But I really value your oppinions, so I will change the behaviour here if this is want most people wants. So what do we/you want? :-) --[[User:FlemmingLarsen|Fnl]] 22:56, 8 August 2009 (UTC)
 +
 +
: Well, the other issues before affect the 'physical' capabilities of the robot, however since this "setAhead(0)" doesn't, why don't we let the bots in question choose the behavior? We could have setAhead() by default behave as 1.6.1.4, but do one of the following so new bots don't have to worry about it:
 +
:# Deprecate setAhead() in favor of something else with more intuitive behavior
 +
:# or, have something like a "AdvancedRobot.useLegacySetAhead(boolean)", which is by default is true, but new bots can set to false
 +
:--[[User:Rednaxela|Rednaxela]] 23:08, 8 August 2009 (UTC)
 +
 +
I suggest we keep the functionality the same for bots that call setAhead() and setBack(), deprecate those methods, and add a new function setDistanceRemaining() which follows the new rules where setDistanceRemaining(0) tries to 'bring you back' to this point if you have a non-zero velocity. The "AdvancedRobot.useLegacySetAhead(boolean)" option would also make it harder for codesize-limited bots to make use of the new rules. --[[User:Skilgannon|Skilgannon]] 23:19, 8 August 2009 (UTC)
 +
 +
Deprecating setAhead and making one that works more intuitively seems like a good option. Maybe setForward / setBackward, same meaning but different words. Not to say it needs to happen in this same version. Of course I agree that setAhead and setBack should continue to function like 1.6.1.4. Really, setAhead(0) seems like a very strange thing to do, anyway, if you ask me. =) So I don't really see it confusing new Robocoders or anything like that. But it's still good for things to be intuitive. --[[User:Voidious|Voidious]] 23:33, 8 August 2009 (UTC)
 +
 +
: Just a note that 1.6.1.4's updateMovement() is really messy, I think it would be good if we can have cleaner implementation. &raquo; <span style="font-size:0.9em;color:darkgreen;">[[User:Nat|Nat]] | [[User_talk:Nat|Talk]]</span> &raquo; 00:10, 9 August 2009 (UTC)
 +
 +
== Nat's updateMovement ==
 +
 +
(edit conflict) Ha ha... When I was adapting Skilgannon's code, I read "if(distance != 0)" as "if(velocity != 0)" so mine has the same result as his. This new code should works then, I spent a lot of time debugging this this morning since I forgot that I have isOverDriving as a static variable, which it mustn't or it will share over all robots =)
 +
<syntaxhighlight>
 +
private boolean isOverDriving = false;
 +
 +
private void updateMovement() {
 +
double distance = currentCommands.getDistanceRemaining();
 +
 +
if (Double.isNaN(distance)) {
 +
distance = 0;
 +
}
 +
 +
velocity = getNewVelocity(velocity, distance);
 +
 +
// If we are over-driving our distance and we are now at velocity=0
 +
// then we stopped.
 +
if (Utils.isNear(velocity, 0) && isOverDriving) {
 +
currentCommands.setDistanceRemaining(0);
 +
distance = 0;
 +
isOverDriving = false;
 +
}
 +
 +
// If we are moving normally and the breaking distance is more
 +
// than remaining distance, enabled the overdrive flag.
 +
if (Math.signum(distance * velocity) != -1) {
 +
if (getDistanceTraveledUntilStop(velocity) > Math.abs(distance)) {
 +
isOverDriving = true;
 +
} else {
 +
isOverDriving = false;
 +
}
 +
}
 +
 +
currentCommands.setDistanceRemaining(distance - velocity);
 +
 +
if (velocity != 0) {
 +
x += velocity * sin(bodyHeading);
 +
y += velocity * cos(bodyHeading);
 +
updateBoundingBox();
 +
}
 +
}
 +
 +
private double getDistanceTraveledUntilStop(double velocity) {
 +
double distance = 0;
 +
velocity = Math.abs(velocity);
 +
while (velocity > 0)
 +
distance += (velocity = getNewVelocity(velocity, 0));
 +
return distance;
 +
}
 +
</syntaxhighlight>
 +
I copied this from updateMovement() of my test version, it should works as expected:
 +
<pre>
 +
1: 0.0, 1000.0
 +
2: 1.0, 999.0
 +
3: 2.0, 997.0
 +
4: 3.0, 994.0
 +
5: 4.0, 990.0
 +
6: 5.0, 985.0
 +
7: 6.0, 979.0
 +
8: 7.0, 972.0
 +
9: 8.0, 964.0
 +
10: 8.0, 0.0
 +
11: 6.0, -6.0
 +
12: 4.0, -10.0
 +
13: 2.0, -12.0
 +
14: -0.0, 0.0
 +
15: 0.0, 0.0
 +
16: 0.0, 0.0
 +
 +
1: 0.0, 1000.0
 +
2: 1.0, 999.0
 +
3: 2.0, 997.0
 +
4: 3.0, 994.0
 +
5: 4.0, 990.0
 +
6: 5.0, 985.0
 +
7: 6.0, 979.0
 +
8: 7.0, 972.0
 +
9: 8.0, 964.0
 +
10: 8.0, -0.01
 +
11: 6.0, -6.01
 +
12: 4.0, -10.01
 +
13: 2.0, -12.01
 +
14: -0.0, -12.01
 +
15: -1.0, -11.01
 +
16: -2.0, -9.01
 +
17: -3.0, -6.01
 +
18: -4.0, -2.01
 +
19: -2.005, -0.004999999999999893
 +
20: -0.004999999999999893, 0.0
 +
21: 0.0, 0.0
 +
22: 0.0, 0.0
 
</pre>
 
</pre>
 +
&raquo; <span style="font-size:0.9em;color:darkgreen;">[[User:Nat|Nat]] | [[User_talk:Nat|Talk]]</span> &raquo; 23:39, 8 August 2009 (UTC)
  
−
The problem was, that is the robot has a velocity of e.g. 8, and we call setAhead(0), the remaining distance would be set to 0. But this is not correct, as the robot needs to brake first, and will move at least 6 + 4 + 2 = 12 pixels more, meaining that it should end with a remaining distance of -12. My new version about take this into account and works in the 1.6.1.4 code. Unfortunately this also means that our Alpha versions are buggy, as I used this improved version for all of them. That might explain the "big" differences in score! I am affraid that we need to do new alphas and retest them all with this issue in mind. Argh! What to do? Should we make new alphas for Hijack 1 and 2 etc. and retest? We could do this + we gain benefits of all bugfixes that have been made since 1.7.1.3. --[[User:FlemmingLarsen|Fnl]] 22:04, 7 August 2009 (UTC)
+
Nice work [[User:Nat|Nat]]! I verified your results, and it works as 1.6.1.4. =)
 +
 
 +
Hence, I intend to use this updateMovement method for version 1.7.1.4. Next question is what getNewMovement method we should use. But this is ongoing on the pool [[User_talk:Voidious/Robocode_Version_Tests|here]] (near the bottom of the page). I think I will stick to the [[Talk:Positive/Optimal_Velocity#Hijack_.3D.29|Hijack]] version by [[User:Skilgannon|Skilgannon]] which uses the old rules, and then produce a final Alpha-8 for all of you to try out. Then I will fix some of the remaining reported bugs on SF and make a Beta later. New features will have to wait for 1.7.2.
 +
 
 +
Man... this movement issue has taken a long time to fix! --[[User:FlemmingLarsen|Fnl]] 13:26, 9 August 2009 (UTC)
 +
 
 +
Finally! A little sad that you chose Skilgannon's not Voidious'. But I do respect your decision as a tie-break. Hmm... 1.7.1 series seem to fixed the movement issue twice.
 +
 
 +
About getNewMovement, I think Voidious' getNewVelocity() and 1.7.1's getUpdateMovement() would be a good combination (the Alpha3), but we need to change Robot API, and thus [[User:Zamboch|Zamboch]] (AKA Pavel Savara) needs to re-generate his .NET =) &raquo; <span style="font-size:0.9em;color:darkgreen;">[[User:Nat|Nat]] | [[User_talk:Nat|Talk]]</span> &raquo; 14:22, 9 August 2009 (UTC)
 +
 
 +
I decided to go for the Alpha-2 (old rules) version, as I expect Skilgammon to vote on this version and because some have voted on Alpha-4, which is closer to the Alpha-2. However, I also think it is a shame if we don't use Voidious' version (new rules) as I think it is more correct. Even through I wrote that I would only add a final Alpha-8 (old rules), I have added a Alpha-9 (new rules) too. This way the ones interrested in trying it out is able to do that. :-) The new alphas can be found [[User_talk:Voidious/Robocode_Version_Tests#New_Alphas|here]]. --[[User:FlemmingLarsen|Fnl]] 20:29, 9 August 2009 (UTC)

Latest revision as of 09:37, 1 July 2010

To not clutter up the Talk:Robocode/Game Physics page:

I believe this is the correct getClosestReachableVelocityToVelocity function (feel free to comment): 

double getClosestReachableVelocityToVelocity(double currentVelocity,double wantedVelocity)
{
 // this function assumes wantedVelocity<=Rules.MAXVELOCITY
 // with this function you can basically assume setAhead(Infinity) or setAhead(-Infinity)
 // was called, and you determine the next velocity based on the max velocity
 // set by the robot. For example, if the current velocity is 0 and the max velocity
 // set was 4.0, it would return 1.0. If the current velocity was 8.0, it would return 6.0.
 if(wantedVelocity<0)
  return -getClosestReachableVelocityToVelocity(-currentVelocity,-wantedVelocity);
 if(currentVelocity<0)
 {
  double nextVelocity;
  // we are travelling the wrong way, decelerate
  nextVelocity = currentVelocity + Rules.DECELERATION;
  if(nextVelocity>Rules.ACCELERATION)
   // make sure we can't jump from -0.1 to 1.9 or something
   nextVelocity = Rules.ACCELERATION;
  if(nextVelocity>wantedVelocity)
   // if the wanted velocity is for example 0.5, limit the velocity to that.
   return wantedVelocity;
  else
   // else return the highest possible
   return nextVelocity;
 }
 else
 {
  if(currentVelocity>wantedVelocity)
  {
   // both velocities are positive, but we need to decelerate
   double nextVelocity = currentVelocity - Rules.DECELERATION;
   if(nextVelocity<wantedVelocity)
    // if we can decelerate more than what's wanted, return what's wanted
    return wantedVelocity;
   else
    // else return the closest to it
    return nextVelocity;
  }
  else
  {
   // the wantedVelocity is higher than current
   double nextVelocity = currentVelocity + Rules.ACCELERATION;
   if(nextVelocity>wantedVelocity)
    // if we can accelerate more than what's wanted, return what's wanted
    return wantedVelocity;
   else
    // else return the closest to it
    return nextVelocity;
  }
 }
}

getMaxVelocity function by Voidious: 

    double getMaxVelocity(double distance)
    {
        if(distance>=20)  // temporary fix, works for maxVelocity==8.0 && maxDecel==2.0
          return Rules.MAX_VELOCITY;
        long decelTime = decelTime(distance);
        double decelDist = (decelTime / 2.0) * (decelTime-1) // sum of 0..(decelTime-1)
            * Rules.DECELERATION;
            
        return ((decelTime - 1) * Rules.DECELERATION) +
            ((distance - decelDist) / decelTime);
    }

    long decelTime(double distance) {
        long x = 1;
        do {
            // (square(x) + x) / 2) = 1, 3, 6, 10, 15...
            if (distance <= ((square(x) + x) / 2) * Rules.DECELERATION) {
                return x;
            }
            x++;
        } while (true);
    }

    long square(long i) {
        return i * i;
    }

The getNewVelocity function: 

    double getNewVelocity(double velocity, double distance) {
    	 if(distance<0)
    	  return -getNewVelocity(-velocity,-distance);
    	  double highestVelocity = getMaxVelocity(distance); // highest velocity without overshooting
    	  double wantedVelocity = Math.min(highestVelocity,currentCommands.getMaxVelocity());
    	      // the actually wanted velocity by the robot is the highest possible,
    	      // limited by what the robot set by the setMaxVelocity command
    	  return getClosestReachableVelocityToVelocity(velocity, wantedVelocity);
    	      // return whatever is closest to that velocity
    }

Simulator: 

    public void simulate()
    {
    	double currentVelocity = 8.0;
    	double distanceRemain = -2.0;
    	while(distanceRemain!=0.0 || currentVelocity!=0.0)
    	{
    		out.println("velocity = "+currentVelocity+"; distance="+distanceRemain);
    		currentVelocity = getNewVelocity(currentVelocity,distanceRemain);
    		distanceRemain -=currentVelocity;
    	}
    }

Results

StartVelocity = 0.0; StartDistance = 6.0; 

velocity = 0.0; distance=6.0
velocity = 1.0; distance=5.0
velocity = 2.0; distance=3.0
velocity = 2.5; distance=0.5
velocity = 0.5; distance=0.0

StartVelocity = 0.0; StartDistance = 10; 

velocity = 0.0; distance=10.0
velocity = 1.0; distance=9.0
velocity = 2.0; distance=7.0
velocity = 3.0; distance=4.0
velocity = 3.0; distance=1.0
velocity = 1.0; distance=0.0

StartVelocity = -1.9; StartDistance = 10; 

velocity = -1.9; distance=10.0
velocity = 0.10000000000000009; distance=9.9
velocity = 1.1; distance=8.8
velocity = 2.1; distance=6.700000000000001
velocity = 3.1; distance=3.600000000000001
velocity = 2.8000000000000007; distance=0.8000000000000003
velocity = 0.8000000000000007; distance=-4.440892098500626E-16;
velocity = -4.440892098500626E-16; distance=0.0

StartVelocity = 8.0; StartDistance = -2.0; 

velocity = 8.0; distance=-2.0
velocity = 6.0; distance=-8.0
velocity = 4.0; distance=-12.0
velocity = 2.0; distance=-14.0
velocity = -0.0; distance=-14.0
velocity = -1.0; distance=-13.0
velocity = -2.0; distance=-11.0
velocity = -3.0; distance=-8.0
velocity = -4.0; distance=-4.0
velocity = -3.0; distance=-1.0
velocity = -1.0; distance=0.0

StartVelocity = 5.0; StartDistance = 40.0; 

velocity = 5.0; distance=40.0
velocity = 6.0; distance=34.0
velocity = 7.0; distance=27.0
velocity = 8.0; distance=19.0
velocity = 7.75; distance=11.25
velocity = 5.75; distance=5.5
velocity = 3.75; distance=1.75
velocity = 1.75; distance=0.0

Original game updateMovement code

    private void updateMovement() {
        double distance = currentCommands.getDistanceRemaining();

        if (Double.isNaN(distance)) {
            distance = 0;
        }

        velocity = getNewVelocity(velocity, distance);

        double dx = velocity * sin(bodyHeading);
        double dy = velocity * cos(bodyHeading);

        x += dx;
        y += dy;

        if (dx != 0 || dy != 0) {
            updateBoundingBox();
        }

        if (distance != 0) {
            currentCommands.setDistanceRemaining(distance - velocity);
        }
    }

Suggested updateMovement code Positive

Now I'm thinking, if the distance remaining == 0.0, and the velocity is set from 6.0 to 4.0, shouldnt the distance remaining become -4.0? Also, the updateBoundingBox is called whenever velocity!=0, because the condition dx==0 && dy==0 is only when the velocity==0, so that can be easier to check. I suggest: 

    private void updateMovement() {
        double distance = currentCommands.getDistanceRemaining();

        if (Double.isNaN(distance)) {
            distance = 0;
        }

        velocity = getNewVelocity(velocity, distance);

	if(velocity!=0)
	{
		x += velocity * sin(bodyHeading);
		y += velocity * cos(bodyHeading);
		updateBoundingBox();
	}

	currentCommands.setDistanceRemaining(distance - velocity);
    }

Corrected updateMovement code

When I run your suggested version against the unit test for 1.6.1.4, I get an error. After some studying and experiments, I found out that the updateMovement() method used in 1.7.1.3 (the "original" on this page) and your suggested version are both buggy. The problem is that the remaining distance is incorrect. The bugfree version compared to 1.6.1.4 is this version: 

	private void updateMovement() {
		double distance = currentCommands.getDistanceRemaining();

		if (Double.isNaN(distance)) {
			distance = 0;
		}

		velocity = getNewVelocity(velocity, distance);

		if (velocity == 0) {
			currentCommands.setDistanceRemaining(0);
		} else {
			currentCommands.setDistanceRemaining(distance - velocity);

			x += velocity * sin(bodyHeading);
			y += velocity * cos(bodyHeading);
			updateBoundingBox();
		}
	}

The problem was, that is the robot has a velocity of e.g. 8, and we call setAhead(0), the remaining distance would be set to 0. But this is not correct, as the robot needs to brake first, and will move at least 6 + 4 + 2 = 12 pixels more, meaining that it should end with a remaining distance of -12. My new version about take this into account and works in the 1.6.1.4 code. Unfortunately this also means that our Alpha versions are buggy, as I used this improved version for all of them. That might explain the "big" differences in score! I am affraid that we need to do new alphas and retest them all with this issue in mind. Argh! What to do? Should we make new alphas for Hijack 1 and 2 etc. and retest? We could do this + we gain benefits of all bugfixes that have been made since 1.7.1.3. --Fnl 22:04, 7 August 2009 (UTC)

Thankyou for taking the time to investigate this, could you please expand on why you added: 

		if (velocity == 0) {
			currentCommands.setDistanceRemaining(0);
		}

Say you are at -2 velocity, and set distance to travel=100. Wouldn't that code cause distance to travel to be incorrectly set to 0? --Positive 23:06, 7 August 2009 (UTC)

Fnl, what I think you are trying to do is prevent bots from reversing back to their original position if setAhead(0) is called? You shouldn't do that by checking if velocity == 0 but rather by checking if distance == 0 because velocity has nothing to do with what the bot passed as an arguments, distance is. So rather have the updateMovement() method as: 

    private void updateMovement() {
	double distance = currentCommands.getDistanceRemaining();

        if (Double.isNaN(distance)) {
		distance = 0;
        }

        velocity = getNewVelocity(velocity, distance);

	if(velocity!=0)
	{
		x += velocity * sin(bodyHeading);
		y += velocity * cos(bodyHeading);
		updateBoundingBox();
	}
        if(distance != 0)
		currentCommands.setDistanceRemaining(distance - velocity);
    }

--Skilgannon 23:21, 7 August 2009 (UTC)

Yes, I believe your version is correct, and that my newest version is buggy (too). Actually, I was using the "if(distance != 0)" in my original code for 1.7.1.3. It seems to work better. And running on the old test cases for 1.6.1.4 shows that the previous version only covers some parts of the errors I saw yesterday with the suggested updateMovement from Positive.

Doh! This means that the new alphas I made yesterday (5, 6, 7) are incorrect too! :-\

Okay, so we should wait on doing new tests, and create new Alphas again, again. I need to try out this new version too. --Fnl 13:16, 8 August 2009 (UTC)

Skilgannon, it seems your version is buggy too. The problem is that is does not take the braking scenario into account I described earlier. E.g. if the robot is moving at velocity 8, has quite some remaining distance left, and then we call setAhead(0), the robot should end with a remaining distance = -12 after the braking has stopped.

  • Time n+0: Velocity = 8, remaining distance = 1000 -> Now we call setAhead(0)
  • Time n+1: Velocity = 8, remaining distance = 0
  • Time n+2: Velocity = 6, remaining distance = -6
  • Time n+3: Velocity = 4, remaining distance = -10
  • Time n+4: Velocity = 2, remaining distance = -12
  • Time n+5: Velocity = 0, remaining distance = -12 -> We have finally stopped

This scenario must be taken into account in order to stay compatible with 1.6.1.4. I guess we need a seperate variable to keep track of the user's setAhead/Back(x) request. --Fnl 13:48, 8 August 2009 (UTC)

Isn't it should be
  • Time n+0: Velocity = 8, remaining distance = 1000 -> Now we call setAhead(0)
  • Time n+1: Velocity = 6, remaining distance = -6
  • Time n+2: Velocity = 4, remaining distance = -10
  • Time n+3: Velocity = 2, remaining distance = -12
  • Time n+4: Velocity = 0, remaining distance = -12 -> We have finally stopped
? Because robot did move once more in each tick. » Nat | Talk » 14:59, 8 August 2009 (UTC)
Yes, you are right here. :-) --Fnl 21:28, 8 August 2009 (UTC)

Let see if this work... 

boolean isOverDriving = false;

private void updateMovement() {
	double distance = currentCommands.getDistanceRemaining();

       	if (Double.isNaN(distance)) {
		distance = 0;
       	}

      	velocity = getNewVelocity(velocity, distance);

	if (velocity == 0 && isOverDriving) {
		currentCommands.setDistanceRemaining(0);
		isOverDriving = false;
	}

	if (Math.signum(distance * velocity) != -1) {
		if (getDistanceTraveledUntilStop(velocity) > Math.abs(distance))
			isOverDriving = true;
		else
			isOverDriving = false;
	}

	if(velocity != 0) {
		x += velocity * sin(bodyHeading);
		y += velocity * cos(bodyHeading);
		updateBoundingBox();
	}
       	
	if(distance != 0)
		currentCommands.setDistanceRemaining(distance - newVelocity);
}

private double getDistanceTraveledUntilStop(double velocity) {
	double distance = 0;
	velocity = Math.abs(velocity);
	while (velocity > 0)
		distance += (velocity = getNewVelocity(velociy, 0));
	return distance;
}

» Nat | Talk » 14:21, 8 August 2009 (UTC)

Testing using hacked Darkcanuck's VelocityTest, my version seems to work fine. » Nat | Talk » 14:59, 8 August 2009 (UTC)

Fnl, with the version I posted as suggestion to the original, it should work like you said. I really can't see why it wouldn't work. To check we are on the same page, if the robot is at 8 velocity, and setAhead(0) is set, it should move backwards after it has overshot, right? If you look at the version I posted, you see the line: 

	currentCommands.setDistanceRemaining(distance - velocity);
    }

Lets say distance is set to 0, and velocity is set to 6. Then distance remaining will be set here to (0 - 6) = -6. And after that (-6 - 4) = -10. Etc. --Positive 17:27, 8 August 2009 (UTC)

Positive, I ran my test again with your version. I am sorry that I wrote that the problem with your version is the remaining distance. This is not the case, as it is perfect in your version. The problem with your version is that when the robot is braking, it does not stop at velocity = 0. It continues to velocity = -1 in the next turn, and afterward -2, where it should have stopped at velocity = 0. This can be seen with the TestBodyTurnRate (using the BodyTurnRate test robot). The additonal check if(distance != 0) by Skilgannon fixes this problem, but wrecks the remaining distance. So we need a method to take both issues into account. :-p Now I will check out Nat's version. I cross my fingers that his version works. --Fnl 21:15, 8 August 2009 (UTC)

Hrm, but what would be the use of getting a distance of -12 at velocity=0, if the robot doesn't try to get to 0 distance by going -1, -2 etc.? I'll try to test with that robot to see what you mean. --Positive 21:47, 8 August 2009 (UTC)

FNL's test robot

Okay, I guees I need to provide a sample robot + give the result I expect so you are able to follow what I am talking about. ;-) Basically, I just want us to be compatible with version 1.6.1.4, at least for the following test.

This robot will show a simple movement: 

public class TestVelocityAndRemainingDist extends robocode.AdvancedRobot {
	public void run() {
		// Set far ahead
		setAhead(1000);

		// Execute for 9 turns
		for (int i = 0; i < 9; i++) {
			executeAndDump();
		}

		// Stop moving
		stopMovingAndDump();
	}

	private void executeAndDump() {
		double lastVelocity = getVelocity();
		double distanceRemaining = getDistanceRemaining();

		execute();

		out.println(getTime() + ": " + lastVelocity + ", " + distanceRemaining);
	}

	private void stopMovingAndDump() {
		setAhead(0);
		setTurnLeft(0);
		
		for (int i = 0; i < 7; i++) {
			executeAndDump();
		}
	}
}

The results (robot output) we get when running this robot in version 1.6.1.4 is: 

1: 0.0, 1000.0
2: 1.0, 999.0
3: 2.0, 997.0
4: 3.0, 994.0
5: 4.0, 990.0
6: 5.0, 985.0
7: 6.0, 979.0
8: 7.0, 972.0
9: 8.0, 964.0
10: 8.0, 0.0
11: 6.0, -6.0
12: 4.0, -10.0
13: 2.0, -12.0
14: 0.0, 0.0
15: 0.0, 0.0
16: 0.0, 0.0

Here the first number is the turn, the second row is the velocity, and the third row is the remaining distance.

--Fnl 21:54, 8 August 2009 (UTC)

When I test using Positive's updateMovement, I get almost the same, but have problems with the velocity in the end: 

...
13: 2.0, -12.0
14: 0.0, -12.0
15: -1.0, -11.0
16: -2.0, -10.0

That is, the velocity should end at 0. So this is bad compared to 1.6.1.4.

When I test using Skilgannon's and also Nat's version of updateMovement, I end with (in both cases): 

...
10: 8.0, 0.0
11: 6.0, 0.0
12: 4.0, 0.0
13: 2.0, 0.0
14: 0.0, 0.0
15: 0.0, 0.0
16: 0.0, 0.0

Here the remaining distance is wrong compared to 1.6.1.4.

--Fnl 22:13, 8 August 2009 (UTC)

(Edit conflict) Okay, so lets say the current velocity is positive, the pseudocode would be (for your suggested behaviour): 

 if remaining distance is positive:
   the next velocity is the closest possible to the max velocity without overshooting
   the next remaining distance is current remaining distance - next velocity
 if remaining distance is negative:
   the next velocity is the closest possible to 0
   if the next velocity is 0:
     the next remaining distance becomes 0
   else
     the next remaining distance becomes current remaining distance - next velocity

Is this correct? --Positive 22:16, 8 August 2009 (UTC)

Yes, this looks right to me. :-) --Fnl 22:31, 8 August 2009 (UTC)
No, if you move backward you will have negative distance remaining and velocity. » Nat | Talk » 23:57, 8 August 2009 (UTC)
Actually, I said "lets say the current velocity is positive". But now I recheck it, the pseudocode would give problems with robots that are at say 8 velocity and want to move -100 (backwards). They'd be cut off at 0 from doing the total move. It's a difficult question, and I think the proposal at the end of this page would be best, leaving the original code as is. --Positive 00:03, 9 August 2009 (UTC)

Heh, and if I make this little tweak and run in 1.6.1.4: 

	private void stopMovingAndDump() {
		setAhead(-0.01);
		setTurnLeft(0);
		
		for (int i = 0; i < 13; i++) {
			executeAndDump();
		}
	}

it gives 

1: 0.0, 1000.0
2: 1.0, 999.0
3: 2.0, 997.0
4: 3.0, 994.0
5: 4.0, 990.0
6: 5.0, 985.0
7: 6.0, 979.0
8: 7.0, 972.0
9: 8.0, 964.0
10: 8.0, -0.01
11: 6.0, -6.01
12: 4.0, -10.01
13: 2.0, -12.01
14: 0.0, -12.01
15: -1.0, -11.01
16: -2.0, -9.01
17: -3.0, -6.01
18: -4.0, -2.01
19: -2.0, -0.009999999999999787
20: -0.009999999999999787, 0.0
21: 0.0, 0.0
22: 0.0, 0.0

showing how near-zero values behave. Ugh... this highly inconsistant behavior between near-zero and zero makes me tempted to suggest something like having setAhead() behave like 1.6.1.4, but make something like a setBetterAhead() with more intuitive/sane behavior. Personally, I can think of little usefulness of the old setAhead() behavior in a new bot, except to annoy the bot author. If an author wants the bot to coast to a stop, the stop() function makes much more sense. Every single movement I've personally written, or seen anyone else write, is based upon either a "goToPoint()" style method, a "setVelocity()" style method, or is a simple oscillator. For simple oscillators or "setVelocity()" method the "setAhead(0)" condition likely never occurs. For a "goToPoint()" style, "setAhead(0)" will almost always be intended to mean "go where I am now". The ONLY case in which I can see people thinking the current behavior of "setAhead(0)" makes sense, is if what they REALLY meant was "setVelocity(0)". --Rednaxela 22:28, 8 August 2009 (UTC)

I really agree with you that the setAhead() and stop is not really intuitive. It fooled me many times as I always forget how it behaves. However, I have never dared to change that as I would break the compatibility and rankings in RoboRumble. ;-) Your idea with setVelocity(0) reminds me of the new robot type in Robocode named RateControlRobot. Go have a look. :-) --Fnl 22:42, 8 August 2009 (UTC)
Interesting, though three things 1) I doubt people really care about the 'rate' often for anything except velocity, 2) Err "setVelocityRate()" seems like a major misnomer. Velocity is the rate of movement, and the rate at which velocity moves is acceleration, so "setVelocityRate()" would logically imply acceleration rather than what it says in those API docs, 3) Since it extends AdvancedRobot and not TeamRobot, you can't use it in a team robot. --Rednaxela 22:53, 8 August 2009 (UTC)
1) Once in a while people have requested this type of robot in order to "simulate" a real robot. So why not? 2) You are right. I need to do some work here. ;-) 3) Again a very good point! This should be easy to fix, and I will. :-) --Fnl 23:03, 8 August 2009 (UTC)
Oh, and also, here's how I deal with setting velocity in all of my recent bots these days: User:Rednaxela/BotBase#MovementActor.java --Rednaxela 23:08, 8 August 2009 (UTC)

Just for the record, I forgot to add the test result for my updateMovement method from yesterday against the TestVelocityAndRemainingDist robot. My version seems works perfect in this specific scenario. But I am still not sure if it is 100% correct. --Fnl 22:31, 8 August 2009 (UTC)

I think like Rednaxela it seems illogical that the distance should first become -12, and then be set to 0 when velocity=0 is reached. I believe there are 2 options:

  1. The overshot is added to the remaining distance (my first suggested code).
  2. Nothing is added to the remaining distance and it stays the same until the robot travels in the right direction. That means that remaining distance would stay at 0 if a robot sets setAhead(0), but will eventually move backwards only by -2 if set with setAhead(-2) independant of what the initial velocity was.

Otherwise what Rednaxela posted will happen (setAhead(-0.01) being treated completely different from setAhead(0)). --Positive 22:40, 8 August 2009 (UTC)

I am not sure what to do. It seems to be most of you want to stick to the behaviour from 1.6.1.4, even if it is odd and hard to understand the behavior. The reason being that you do not want to wreck rankings etc. for the RoboRumble, which is reasonable, but also to allow old robots to run the same way as in previous versions. In the discussion of old versus new rules, most people seems to want stick to the old rules, but without the bugs that can be fixed with little impact. So if we change the rules with the remaining distance here compared to 1.6.1.4, this might have an impact on both compatibility and rankings. But I really value your oppinions, so I will change the behaviour here if this is want most people wants. So what do we/you want? :-) --Fnl 22:56, 8 August 2009 (UTC)

Well, the other issues before affect the 'physical' capabilities of the robot, however since this "setAhead(0)" doesn't, why don't we let the bots in question choose the behavior? We could have setAhead() by default behave as 1.6.1.4, but do one of the following so new bots don't have to worry about it:
  1. Deprecate setAhead() in favor of something else with more intuitive behavior
  2. or, have something like a "AdvancedRobot.useLegacySetAhead(boolean)", which is by default is true, but new bots can set to false
--Rednaxela 23:08, 8 August 2009 (UTC)

I suggest we keep the functionality the same for bots that call setAhead() and setBack(), deprecate those methods, and add a new function setDistanceRemaining() which follows the new rules where setDistanceRemaining(0) tries to 'bring you back' to this point if you have a non-zero velocity. The "AdvancedRobot.useLegacySetAhead(boolean)" option would also make it harder for codesize-limited bots to make use of the new rules. --Skilgannon 23:19, 8 August 2009 (UTC)

Deprecating setAhead and making one that works more intuitively seems like a good option. Maybe setForward / setBackward, same meaning but different words. Not to say it needs to happen in this same version. Of course I agree that setAhead and setBack should continue to function like 1.6.1.4. Really, setAhead(0) seems like a very strange thing to do, anyway, if you ask me. =) So I don't really see it confusing new Robocoders or anything like that. But it's still good for things to be intuitive. --Voidious 23:33, 8 August 2009 (UTC)

Just a note that 1.6.1.4's updateMovement() is really messy, I think it would be good if we can have cleaner implementation. » Nat | Talk » 00:10, 9 August 2009 (UTC)

Nat's updateMovement

(edit conflict) Ha ha... When I was adapting Skilgannon's code, I read "if(distance != 0)" as "if(velocity != 0)" so mine has the same result as his. This new code should works then, I spent a lot of time debugging this this morning since I forgot that I have isOverDriving as a static variable, which it mustn't or it will share over all robots =) 

	private boolean isOverDriving = false;

	private void updateMovement() {
		double distance = currentCommands.getDistanceRemaining();

		if (Double.isNaN(distance)) {
			distance = 0;
		}

		velocity = getNewVelocity(velocity, distance);

		// If we are over-driving our distance and we are now at velocity=0
		// then we stopped.
		if (Utils.isNear(velocity, 0) && isOverDriving) {
			currentCommands.setDistanceRemaining(0);
			distance = 0;
			isOverDriving = false;
		}

		// If we are moving normally and the breaking distance is more
		// than remaining distance, enabled the overdrive flag.
		if (Math.signum(distance * velocity) != -1) {
			if (getDistanceTraveledUntilStop(velocity) > Math.abs(distance)) {
				isOverDriving = true;
			} else {
				isOverDriving = false;
			}
		}
		
		currentCommands.setDistanceRemaining(distance - velocity);

		if (velocity != 0) {
			x += velocity * sin(bodyHeading);
			y += velocity * cos(bodyHeading);
			updateBoundingBox();
		}
	}

	private double getDistanceTraveledUntilStop(double velocity) {
		double distance = 0;
		velocity = Math.abs(velocity);
		while (velocity > 0)
			distance += (velocity = getNewVelocity(velocity, 0));
		return distance;
	}

I copied this from updateMovement() of my test version, it should works as expected: 

1: 0.0, 1000.0
2: 1.0, 999.0
3: 2.0, 997.0
4: 3.0, 994.0
5: 4.0, 990.0
6: 5.0, 985.0
7: 6.0, 979.0
8: 7.0, 972.0
9: 8.0, 964.0
10: 8.0, 0.0
11: 6.0, -6.0
12: 4.0, -10.0
13: 2.0, -12.0
14: -0.0, 0.0
15: 0.0, 0.0
16: 0.0, 0.0

1: 0.0, 1000.0
2: 1.0, 999.0
3: 2.0, 997.0
4: 3.0, 994.0
5: 4.0, 990.0
6: 5.0, 985.0
7: 6.0, 979.0
8: 7.0, 972.0
9: 8.0, 964.0
10: 8.0, -0.01
11: 6.0, -6.01
12: 4.0, -10.01
13: 2.0, -12.01
14: -0.0, -12.01
15: -1.0, -11.01
16: -2.0, -9.01
17: -3.0, -6.01
18: -4.0, -2.01
19: -2.005, -0.004999999999999893
20: -0.004999999999999893, 0.0
21: 0.0, 0.0
22: 0.0, 0.0

» Nat | Talk » 23:39, 8 August 2009 (UTC)

Nice work Nat! I verified your results, and it works as 1.6.1.4. =)

Hence, I intend to use this updateMovement method for version 1.7.1.4. Next question is what getNewMovement method we should use. But this is ongoing on the pool here (near the bottom of the page). I think I will stick to the Hijack version by Skilgannon which uses the old rules, and then produce a final Alpha-8 for all of you to try out. Then I will fix some of the remaining reported bugs on SF and make a Beta later. New features will have to wait for 1.7.2.

Man... this movement issue has taken a long time to fix! --Fnl 13:26, 9 August 2009 (UTC)

Finally! A little sad that you chose Skilgannon's not Voidious'. But I do respect your decision as a tie-break. Hmm... 1.7.1 series seem to fixed the movement issue twice.

About getNewMovement, I think Voidious' getNewVelocity() and 1.7.1's getUpdateMovement() would be a good combination (the Alpha3), but we need to change Robot API, and thus Zamboch (AKA Pavel Savara) needs to re-generate his .NET =) » Nat | Talk » 14:22, 9 August 2009 (UTC)

I decided to go for the Alpha-2 (old rules) version, as I expect Skilgammon to vote on this version and because some have voted on Alpha-4, which is closer to the Alpha-2. However, I also think it is a shame if we don't use Voidious' version (new rules) as I think it is more correct. Even through I wrote that I would only add a final Alpha-8 (old rules), I have added a Alpha-9 (new rules) too. This way the ones interrested in trying it out is able to do that. :-) The new alphas can be found here. --Fnl 20:29, 9 August 2009 (UTC)

Retrieved from "http://robowiki.net/w/index.php?title=User:Positive/Optimal_Velocity&oldid=16901"