Virtual bullet doesn't line up with real bullets
The highlighted comment was created in this revision.
I would guess this is the result of the Robocode idiosyncrasy where a bullet is fired before the gun is turned (so if you do setTurnGunRightDegrees(10), setFire(3), execute(), the bullet is fired before the gun is turned right 10 degrees). So your actual aim is probably the aim from the previous turn, while your predicted is from the current turn.
Well... can't really tell without more information what's wrong, but my first guess about what's wrong, is that perhaps you're not accounting for how within a tick, firing happens before gun turning does. The angle you fire at when you call setFire() is the angle resulting from the prior tick's setTurnGun() type call.
Yeah that's correct, the setFire is from the last tick.
What's a typical pattern for robocode as to code placement? I'm currently placing the gun turning code in the while true loop and the firing code in onScannedRobot
and it's wrapped with if (getGunHeat() == 0.0)
Should I change that layout? (also add && getGunTurnRemaining() == 0.0 to the fire wrap?)