Talk:Diamond/Code

From Robowiki
< Talk:Diamond
Revision as of 15:52, 28 January 2010 by Voidious (talk | contribs) (→‎Code editing: agree)
(diff) ← Older revision | Latest revision (diff) | Newer revision → (diff)
Jump to navigation Jump to search

Interesting code

Your kd-tree seems almost as long as mine (just not seperated), I should try jamming mine down and see how small I can get it. --Chase 17:58, 16 May 2009 (UTC)

Not sure if you're accounting for this, but there's a lot of fluff left in the files as posted. It would look a lot shorter if you removed the commented out debugging and the diagnostics stuff... But I favor code clarity and performance over condensing code, anyway. I thought it would be a lot longer, actually. =) This kd-tree stuff isn't quite as complex as I expected. --Voidious 18:11, 16 May 2009 (UTC)

Its not really complex nope, and I have some real fluff in mine to, for clarity reasons. I could cut out the PointKD, the RectKD and combine the NodeKD, BranchKD, and BucketKD into the tree class. I use the rectKD for hyper rectangles based on data inserted down the branch so I have to only search if there is chance of it actually being anything closer on that down line. --Chase 18:21, 16 May 2009 (UTC)

Code editing

Last revision of this page: [1] has edit the code snippet. Personally I don't like this change, since it is snippet of a robot, which shouldn't be edit to be different from the original robot. Should we revert this change? --Nat Pavasant 11:39, 28 January 2010 (UTC)

I would agree for the same reason, though I hate to discourage a new RoboWiki contributor. =) The code changes themselves look fine, but since this page is code snippets from Diamond, it seems a little weird... --Voidious 14:52, 28 January 2010 (UTC)